Skip to content

cmake: Remove MbedTLS custom finder - #13865

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:remove_mbedtls_finder
Sep 4, 2026
Merged

cmake: Remove MbedTLS custom finder#13865
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:remove_mbedtls_finder

Conversation

@tytan652

@tytan652 tytan652 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Remove MbedTLS custom finder since all platforms should provide the CMake package now.

Motivation and Context

The CMake package provided by upstream was preferred but macOS build were without it until recently.

How Has This Been Tested?

CI is the test since I only have Linux machines.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added the kind/cleanup Non-breaking change which makes code smaller or more readable label Sep 3, 2026
The CMake package provided by upstream was preferred but macOS build
were without it until recently.
@tytan652
tytan652 force-pushed the remove_mbedtls_finder branch from 9b6d8bb to ae6fc07 Compare September 3, 2026 15:38
@tytan652
tytan652 requested a review from PatTheMav September 3, 2026 16:06

@PatTheMav PatTheMav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you require to consider your PR tested (for the checklist)?

@tytan652

tytan652 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Forgot to check the box after CI passed (since all platform found MbedTLS).

@RytoEX RytoEX added this to the OBS Studio 33.0 milestone Sep 4, 2026
@github-project-automation github-project-automation Bot moved this to Ready For Review in 33.0 Release Tracker Sep 4, 2026
@RytoEX
RytoEX merged commit 6b3e550 into obsproject:master Sep 4, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Ready For Review to Merged in 33.0 Release Tracker Sep 4, 2026
@tytan652
tytan652 deleted the remove_mbedtls_finder branch September 5, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Non-breaking change which makes code smaller or more readable

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants